search

nus-cs2103-AY2223S2 / pe-dev-response

1 stars 0 forks source link

Editing the name in the Json file overrides the same name check and wipes the data. #2509

Open nus-pe-bot opened 1 year ago

nus-pe-bot commented 1 year ago

image.png

image.png

Problem: When editing an existing person's name to another existing person (Cat ng to cat ng), the app wipes the entire data file although the format of the Json file is still correct.

[original: nus-cs2103-AY2223S2/pe-interim#3279] [original labels: severity.High type.FeatureFlaw]

leonpoh commented 1 year ago

Team's Response

Thank you for the information.

As a data file containing duplicate persons is not a valid list allowed by the application, rejecting it is the intended behaviour as specified by the User Guide's warning below. Furthermore, the application does not delete or overwrite such a data file until new commands are entered - providing the user room to recover even if he/she has attempted to edit it without maintaining backups.

However, we understand your concerns over data integrity - implementing data recovery from a malformed file would be a useful future addition to the application.

image.png

Duplicate status (if any):

--