nus-cs2103-AY2223S2 / pe-dev-response

1 stars 0 forks source link

Adding another person with same name but additional spacing between words is allowed #2537

Open nus-pe-bot opened 1 year ago

nus-pe-bot commented 1 year ago

Description Able to add another person into the addressbook by adding a space between the 2 words of the name. This makes it challenging for users of the app to perform operations on said person, if they had accidentally entered a white space as it is treated as another person, and operations will not go through

Steps to Reproduce Add a whitespace " " between the 2 words of the name

Expected behaviour The app should take this into account and throw an error saying the person already exists

Actual behaviour The name is treated differently and a new person is added to the application

Screenshots

Screenshot 2023-04-14 at 2.33.12 PM.png

Environment Information macOS Ventura Version 13.0.1


[original: nus-cs2103-AY2223S2/pe-interim#2020] [original labels: type.FunctionalityBug severity.High]

WindyCall commented 1 year ago

Team's Response

微信截图_20230417212419.png

Basically, as I underlined above, this bug will only be considered a type.FeatureFlaw if the product has a built-in duplicate detection feature. However, our product makes use of exact string matches for name, therefore, for your example given, as long as the name is not exactly matched, we will treat these as two different people, which lead to no bugs.

Another thing is that as this might not happen to most of the users and the frequency is low, this should not be treated as High priority bug since there's no serious data loss or cause of system corruption.

Also, as stated from above diagram, I admitted that it's better to warn users if a near-match happens, therefore, instead of rejecting this issue, I make it with Low priority and type.FeatureFlaw.

Hope this clarifies.

Duplicate status (if any):

--