nus-cs2103-AY2223S2 / pe-dev-response

1 stars 0 forks source link

[Editing Vaccination] Allows duplicate vaccination names which differ by whitespace #2770

Open nus-pe-bot opened 1 year ago

nus-pe-bot commented 1 year ago

Description

Can edit the name of a vaccination to a similar vaccination existing in the list, with difference being whitespace only.

Steps for reproducing

edit INDEX::1 --n Dose 1(Moderna) --lal 5 --ual 25 --i NaOH --set true

Expected Output

Should not allow this edit as Dose 1 (Moderna) should be the same as Dose1(Moderna)

Actual Output

Allows the edit to be done

Screenshots

_{[original: nus-cs2103-AY2223S2/pe-interim#2180] [original labels: severity.Low type.FeatureFlaw]}

daitenshionyan commented 1 year ago

Team's Response

In english, the word(s) "MAYBE" and "MAY BE" mean different things. This shows that spaces introduces new meanings.

This is the same for names as well.

If the user wants to differentiate between the vaccination "VAXA" which may be the name of a vaccination and "VAX A" which may be the A type of the vaccination VAX, the space is required.

Hence, vaccinations should be differentiated by spaces. This is the same for patient names, allergy names and all names in general. Eg. ZHIYONG vs ZHI YONG.