nus-cs2103-AY2223S2 / pe-dev-response

1 stars 0 forks source link

Undo command does not undo list, find commands #3335

Open nus-pe-bot opened 1 year ago

nus-pe-bot commented 1 year ago

Expected

The undo command should also undo the list and find commands

Actual

The undo command does not undo them, which can lead to unexpected behaviour.

Steps to Reproduce

  1. Start the application
  2. Run the list command

w:400 image.png

  1. Run the undo command

image.png An error is encountered.


[original: nus-cs2103-AY2223S2/pe-interim#4402] [original labels: severity.Low type.FunctionalityBug]

Tempura-Person commented 1 year ago

Team's Response

Thank you for bringing this to our attention.

However, I disagree with this issue. The undo command does not undo the list and find commands intentionally by design.

The undo command was created to undo unintentional changes to the contact and session lists by the user.

Thus, undo only undoes commands that directly modify the states of these lists. (e.g. add, student-add...)

list and find do not edit these lists whatsoever and only displays their contents.

There is no need to undo these commands as there are no mistakes made to undo.

Duplicate status (if any):

--