nus-cs2103-AY2223S2 / pe-dev-response

1 stars 0 forks source link

Poor Phone Number validation rules #3672

Open nus-pe-bot opened 1 year ago

nus-pe-bot commented 1 year ago

While it is stated that a phone number may be a string of numbers, but invalid numbers such as 00000000 can be saved, which in the context of a GP clinic is not useful


Screenshot 2023-04-14 at 3.07.17 PM.png


[original: nus-cs2103-AY2223S2/pe-interim#3022] [original labels: severity.Low type.FeatureFlaw]

Jiayan-Lim commented 1 year ago

Team's Response

We acknowledge that the phone number validation can be improved, as indicated in one of the planned enhancements listed in the 'Appendix' of the Developer Guide.

We understand that the tester may have concerns about the current approach, as it allows users to input non-valid phone numbers. However, our goal is to provide users with more flexibility when entering phone numbers.

In the current phase, we have prioritized flexibility over strict validation for the phone field. While there may be room for improvement, we believe that this approach provides users with more options for entering their phone numbers.

Duplicate status (if any):

--