search

nus-cs2103-AY2223S2 / pe-dev-response

1 stars 0 forks source link

[Editing vaccination] Should be more restrictive to prevent potential mistakes in accuracy of information #3706

Open nus-pe-bot opened 1 year ago

nus-pe-bot commented 1 year ago

Description

You are able to edit the vaccination detail specifically the group attribute to anything. For example for a Dose 2 (Moderna) u can assign a group Dose 5

Steps for Reproducing

vaccination edit INDEX::4 --lal 5 --ual 25 --i NaOH --g Dose 5--set true

Expected Output

Should not allow me to assign this group

Actual Output

Allows the assignment to proceed.

Screenshots

image.png

[original: nus-cs2103-AY2223S2/pe-interim#3099] [original labels: severity.Low type.FeatureFlaw]

francisyzy commented 1 year ago

Team's Response

Group attribute is a user defined term. The user can enter any valid group-name that can help him identify the vaccination better.

Everyone has their own way of organising vaccination groups. Thus we we would like to leave it to the user and not restrict them in anyway. Dose 5 or even Pasta may have no relation to the vaccines that in our point of view, however, to someone else, they may mean something else. There could be a vaccine named Dose 2 (DOSE 5) where "DOSE" may be an abbreviation of something in someone elses eyes.

For these cases, we feel that resricting such names would only annoy the user and would consider as over zealeous validation.

Duplicate status (if any):

--