search

nus-cs2103-AY2324S1 / forum

10 stars 0 forks source link

Bug for UG and validation of courses #404

Open leontan2 opened 9 months ago

leontan2 commented 9 months ago

Hi prof @damithc, my team has an enquiry and would like to seek your guidance. My team's product would validate the courses added as part of the Add Command through an array of strings containing the courses. This array of valid mods was retrieved on the 4th of Oct 2023 on NUSMods.

However, as of today, more mods are being added to NUSMods. Due to the constraints of the course, we are unable to do a live update of mods.

Hence we were wondering if we are allowed to change the array of strings to include the new mods added as shown in NUSMods?

In addition, if there were to happen to have another mod added in after v1.4 then how are we to go around this?

On a side note, are we able to add in more courses such as those from the special terms as well?

Thank you so much, prof!

damithc commented 9 months ago

@leontan2

Hence we were wondering if we are allowed to change the array of strings to include the new mods added as shown in NUSMods?

Yes.

In addition, if there were to happen to have another mod added in after v1.4 then how are we to go around this?

In the UG, you can mention the course list up to which date is being supported, and the ability to live update the list is coming in a later version.

On a side note, are we able to add in more courses such as those from the special terms as well?

Only if v1.3 also included special sem courses. If not, this too can be a planned enhancement.

leontan2 commented 9 months ago

Thanks for the quick reply prof. Just one more further clarification. For the course validation before PED, we didnt explicitly say the mods are from NUSMods S1/S2 but just simply stated that "we only accept valid courses", does this grant us the ticket to update the array of strings to the latest nusmods api?

damithc commented 9 months ago

Thanks for the quick reply prof. Just one more further clarification. For the course validation before PED, we didnt explicitly say the mods are from NUSMods S1/S2 but just simply stated that "we only accept valid courses", does this grant us the ticket to update the array of strings to the latest nusmods api?

@leontan2 was special sem courses available to be accessed in the PED jar or mentioned in the UI? If the answer is 'no' to both, we have to conclude that it was not supported at PED and adding support to it now will be an enhancement.