search

nus-cs2103-AY2324S1 / forum

10 stars 0 forks source link

Feature Flaw or Functionality #533

Open dhruvir29 opened 1 year ago

dhruvir29 commented 1 year ago

During my PE, I found that the group did not handle an invalid input - When I tried deleting a class that does not exist, there was a Java Exception caused and so there was no error message that popped up (and the command result message box did not change). I had specified this bug to be a functionality bug but the dev team disagreed and tagged it as a feature flaw. Can I clarify that this is a functionality bug and not a feature flaw as this functionality doesn't work as expected as we would expect an error message when the user tries to delete a class that is not in the list, which the user might accidentally try to do and so is a legitimate user behaviour that is unhandled.

damithc commented 1 year ago

@dhruvir29 Failing silently (i.e., give no indication that the action failed) can be considered a bug, unless the app is designed in a way that users would know that silence indicates action failure (this is rare).

dhruvir29 commented 1 year ago

Can I clarify if that means that it is considered a Functionality flaw?

Tim-Siu commented 1 year ago

@dhruvir29 Failing silently (i.e., give no indication that the action failed) can be considered a bug, unless the app is designed in a way that users would know that silence indicates action failure (this is rare).

Hello Professor, if such bug is already acknowledged in a 'Planned Enhancement' section, can I still file a separate bug report? For more context, please refer to my post #524 . Thanks!

damithc commented 1 year ago

Can I clarify if that means that it is considered a Functionality flaw?

@dhruvir29 I try to avoid giving a decision on specific cases (the decision should be yours). In the following general comment, I used bug to mean a FunctionalityBug

Failing silently (i.e., give no indication that the action failed) can be considered a bug, unless the app is designed in a way that users would know that silence indicates action failure (this is rare).

If the current behavior is reasonable, and seems to be a deliberate design decision (e.g., the UG explains the current behavior clearly or it is how normally such a feature behaves), then any further improvement corresponds to a FetureFlaw. Otherwise (ie., the problem seem to be caused by an oversight or incorrect logic), it is a FunctionalityBug.

Hello Professor, if such bug is already acknowledged in a 'Planned Enhancement' section, can I still file a separate bug report? For more context, please refer to my post #524 . Thanks!

@Tim-Siu Planned enhancements were not meant to cover FunctionalityBugs, such bugs were allowed to be fixed in v1.4