nus-cs2103-AY2324S1 / pe-dev-response

0 stars 0 forks source link

Able to add in the exact same contact if there are extra spaces between the name #1000

Open nus-se-script opened 10 months ago

nus-se-script commented 10 months ago

Steps to reproduce:

  1. Enter command: " add n/John Doe p/98765432 e/johnd@example.com o/Barber a/John Street, Block 123, #01-01".

  2. Enter command: add n/John Doe p/98765432 e/johnd@example.com o/Barber a/John Street, Block 123, #01-01". (Notice the difference here is that there is one more extra space between John and Doe in the name)

Expected output: An error message stating that the contact already exists.

Actual output: Duplicated contact is added.

Here is the screenshot for the duplicated contacts being added:

image.png

Description: When typing, it is normal for users to accidentally enter extra spaces here and there. In this way, this bug will allow duplicated contacts to be added even without the user knowing.


[original: nus-cs2103-AY2324S1/pe-interim#845] [original labels: type.FeatureFlaw severity.Medium]

bhnuka commented 10 months ago

Team's Response

To do with lack of Duplicate Detection for Names (Spaces). Hence accepted.

Duplicate status (if any):

--