Description: Perhaps your validation checks for email are too stringent? I understand that the use case of this application is targeted at Singaporeans, and you mentioned in your planned enhancements that you will be adding other domains in the future. However, according to Wikipedia, there exist other valid forms of email addresses which are currently being rejected as well. I do concede that the likelihood of such a thing occuring is very low.
For instance, according to wikipedia:
The following are valid traditional email addresses:
Abc@example.com (English, ASCII)
Abc.123@example.com (English, ASCII)
user+mailbox/department=shipping@example.com (English, ASCII)
!#$%&'*+-/=?^_`.{|}~@example.com (English, ASCII)
"Abc@def"@example.com (English, ASCII)
"Fred\ Bloggs"@example.com (English, ASCII)
"Joe.\Blow"@example.com (English, ASCII)
The following are all valid international email addresses:
用户@例子.广告 (Chinese, Unicode)
ಬೆಂಬಲ@ಡೇಟಾಮೇಲ್.ಭಾರತ (Kannada, Unicode)
अजय@डाटा.भारत (Hindi, Unicode)
квіточка@пошта.укр (Ukrainian, Unicode)
χρήστης@παράδειγμα.ελ (Greek, Unicode)
Dörte@Sörensen.example.com (German, Unicode)
коля@пример.рф (Russian, Unicode)
Steps to reproduce:
Tried using the add_contact command to add the following person in with the valid email address:
addcontact n/Valid Name p/12345678 e/!#$%&'*+-/=?^`.{|}~@example.com a/##
Received error message as seen in the following screenshot
Description: Perhaps your validation checks for email are too stringent? I understand that the use case of this application is targeted at Singaporeans, and you mentioned in your planned enhancements that you will be adding other domains in the future. However, according to Wikipedia, there exist other valid forms of email addresses which are currently being rejected as well. I do concede that the likelihood of such a thing occuring is very low.
For instance, according to wikipedia:
The following are valid traditional email addresses: Abc@example.com (English, ASCII) Abc.123@example.com (English, ASCII)
user+mailbox/department=shipping@example.com (English, ASCII) !#$%&'*+-/=?^_`.{|}~@example.com (English, ASCII) "Abc@def"@example.com (English, ASCII) "Fred\ Bloggs"@example.com (English, ASCII) "Joe.\Blow"@example.com (English, ASCII)
The following are all valid international email addresses: 用户@例子.广告 (Chinese, Unicode) ಬೆಂಬಲ@ಡೇಟಾಮೇಲ್.ಭಾರತ (Kannada, Unicode) अजय@डाटा.भारत (Hindi, Unicode) квіточка@пошта.укр (Ukrainian, Unicode) χρήστης@παράδειγμα.ελ (Greek, Unicode) Dörte@Sörensen.example.com (German, Unicode) коля@пример.рф (Russian, Unicode)
Steps to reproduce:
Tried using the add_contact command to add the following person in with the valid email address: addcontact n/Valid Name p/12345678 e/!#$%&'*+-/=?^`.{|}~@example.com a/##
Received error message as seen in the following screenshot
Here is another:
[original: nus-cs2103-AY2324S1/pe-interim#882] [original labels: type.FeatureFlaw severity.VeryLow]