nus-cs2103-AY2324S1 / pe-dev-response

0 stars 0 forks source link

Address validation unclear #1093

Open nus-se-script opened 12 months ago

nus-se-script commented 12 months ago

Someone lives in an electronic house (e/house for short).

I want to set their address to e/house, which is allowed based on the user guide

image.png

edit_person 1 a/ e/house causes an error, though having spaces after the flag usually works.

However, edit_person 1 a/e/house works.

This is not documented in the User Guide.


[original: nus-cs2103-AY2324S1/pe-interim#925] [original labels: severity.Low type.DocumentationBug]

nicleongyj commented 12 months ago

Team's Response

This is documented in the user guide

Screenshot 2023-11-20 at 1.11.34 AM.png

As stated in the UG, a/ accepts empty strings and will clear existing values in address, and in your command "a/" will be deemed as a prefix to clear existing address values. Hence "e/house" will be considered as a email prefix in this case and "house" is not a valid email stated in the UG.

In your valid command, "a/e/house", the input value for the "a/" prefix is non-empty and "a/house" will be taken as input values for address, hence it is a valid command.

Duplicate status (if any):

--