nus-cs2103-AY2324S1 / pe-dev-response

0 stars 0 forks source link

No duplicate detection for phone number #1198

Open nus-se-script opened 10 months ago

nus-se-script commented 10 months ago

image.png There is no duplication check for the phone number and will not show any message if the newly added person shares a same phone number as any of the existing people. In reality, usually it is not possible for 2 people sharing the same number and this is very likely caused by a typo, which a confirmation message or error message is recommended to be displayed.


[original: nus-cs2103-AY2324S1/pe-interim#1024] [original labels: severity.Low type.FeatureFlaw]

freshcabbage123 commented 10 months ago

Team's Response

Following similar reasoning, it is very likely in the real world for 2 people to share the same numbers i.e. colleagues in the same department sharing a common office number.

Duplicate status (if any):

Duplicate of #5148