search

nus-cs2103-AY2324S1 / pe-dev-response

0 stars 0 forks source link

Insufficient validation for courses #1222

Open nus-se-script opened 7 months ago

nus-se-script commented 7 months ago

Considering the niche target users of NUS Computing students, it would make sense for the course field to validate the course ID, maybe with data from the university, or checking if the general format of a typical NUS course id.

Currently, adding nonsensical course IDs is possible.

image.png

[original: nus-cs2103-AY2324S1/pe-interim#1858] [original labels: severity.Low type.FeatureFlaw]

nknguyenhc commented 7 months ago

Team's Response

First, our course is not necessarily course ID. User can decide how to store the courses. For example, they can store the full name, Data Structures and Algorithms, or course ID, CS2040S.

Your suggestion does not improve our user experience, for the following reasons:

  1. For a normal user, the course name may give faster information than the course ID. For example, when the user is looking for someone with more AI experience, does the set of courses CS2109S, CS3264, CS4248, or the set of courses Intro to AI, Foundation of ML, NLP give more information to you? We think that the latter gives more information. You might think otherwise. It is a matter of personal preference, and we should not force the user to only store by course ID.

  2. We did specify that our target user is NUS computing students and professionals, but we do not force them to only network with other NUS SoC students and professionals. Let's say if an NUS computing student is to network with an NTU student, this implies that we have to import the list of courses from NTU, and all other universities. This should not be in our scope of work.

Duplicate status (if any):

--