search

nus-cs2103-AY2324S1 / pe-dev-response

0 stars 0 forks source link

Fail to handle duplicate in person names #124

Open nus-se-script opened 9 months ago

nus-se-script commented 9 months ago

@CS2103T-T12-2

Screenshot from App: image.png

image.png

James Ho and james ho are likely to be the same person. Similarly, extra white space is unlikely to mean they are two different persons .Typically, it is best if you can give a warning in such near match cases so that the user can make the final decision.

If you app has a duplicate detection feature, make sure its limitations are made clear to the user so that users are not led to believe that duplicates are being detected while many potential duplicate cases go undetected. Otherwise, it can be considered a type.FeatureFlaw.

To duplicate, add contacts/persons with name 'James Ho', 'james ho' and 'James Ho' respectively.

[original: nus-cs2103-AY2324S1/pe-interim#155] [original labels: severity.Low type.FeatureFlaw]

Kurtyjlee commented 9 months ago

Team's Response

This is very clearly stated in the user guide that exact names are not allowed. Moreover, names are not case-sensitive as well. This is designed to give users flexibility in naming their contacts and we do not want to dictate that feature for them.

Duplicate status (if any):

--