nus-cs2103-AY2324S1 / pe-dev-response

0 stars 0 forks source link

Mandating course codes to be searchable on NUSMods #1308

Open nus-se-script opened 9 months ago

nus-se-script commented 9 months ago

As there are credit-bearing courses that are not listed on NUSMods (eg CP3200, industry attachments programmes/internships, DYOMs), would it be better if we don't strictly block course codes that are not listed?

As there course codes are only relevant in name (there's no additional feature to link to NUSMods or anything), perhaps a warning would better suffice instead of a blanket ban?


[original: nus-cs2103-AY2324S1/pe-interim#1961] [original labels: type.FeatureFlaw severity.Medium]

joel-foo commented 9 months ago

Team's Response

Hello! Thank you for your input on your bug. However, we have decided to reject this and that the severity should be reduced from Medium to Low.

Why should it be rejected?

NUSCoursemates utilises NUSMods API to check on the validity of the courses for AY 2023/2024 Sem 1 or Sem 2 and it was stated in our User Guide that we are only following the valid courses updated as of 11 Nov 2023.

Screenshot 2023-11-20 at 11.35.19 PM.png

However, it will be updated in v2.0 as well as our implementation of the live tracking of courses. We have included this in our planned enhancements in Appendix C.5.

Screenshot 2023-11-20 at 11.40.14 PM.png

In addition, we have also consulted Prof Damith on this situation in forum issue #404 and his guidance is that if a course is added after our stipulated date of update, it will be fine due to the constraints of the project.

Screenshot 2023-11-20 at 11.42.11 PM.png

Moreover, our team would like to address the given example, CP3200. This course is invalid as it is not offered in AY2023/24 for both sem 1 and sem 2.

Screenshot 2023-11-20 at 11.35.01 PM.png

In addition, it is untrue that NUSCoursemates does not accept industry attachment programmes and DYOMs. As shown below, NUSCoursemates accept such courses but there might be courses that have been added after 11 November and hence are not recognised by NUSCoursemates.

Screenshot_2023-11-20_at_11.46.51_PM.png

Lastly, there is a link to NUSMods on the UG, which directs the user to what are considered valid courses. The ban has to be enforced, or else there will be no way to perform course validation, which is vital to maintaining the integrity of the data in our app.

Why should it be severity low?

If the teaching team decides to accept this as a valid bug (for reasons unbeknownst to us), we would categorise it under severity.Low as it would only cause a minor inconvenience to our users in rare occasions. We believe that it should not be deemed as severity medium as this is a rare occurrence for users, majority of NUS SoC students would not take courses such as "CP3200, industry attachments programmes/internships, DYOMs" and utilise NUSCoursemates at the same time as NUSCoursemates intent is always for easy management and tracking of your peers during the semester. However, we have a stronger justification for this bug to be rejected.

Duplicate status (if any):

--