nus-cs2103-AY2324S1 / pe-dev-response

0 stars 0 forks source link

Lack of verification for address parameters #1555

Open nus-se-script opened 11 months ago

nus-se-script commented 11 months ago

When using the command add n/kok p/911 e/d_d@example a/a/ r/likes to swim t/friends t/owesMoney

The command doesn't check for invalid parameters for the address field and accepts the invalid input as shown above.

Screenshot 2023-11-17 at 4.31.24 PM.png

In fact, it seems that it doesn't do any verification to check the correct data type. This could potentially confuse the user if they accidentally enter a wrong format as it doesn't give the appropriate error message.


[original: nus-cs2103-AY2324S1/pe-interim#2264] [original labels: severity.Low type.FeatureFlaw]

adhigop13 commented 11 months ago

Team's Response

Address of locations can vary widely depending on the country, state, and city. There can be alphabets, numbers, '#' , and other special characters. Hence, we made a conscious design decision to not enforce any checks while typing out the address. So this is not really in scope of the feature that we are implementing in this project.

Duplicate status (if any):

--