It is possible to add the same employee with the same name

[nus-se-script]

The user guide does not specify that the same name can be added.

Having seemly identical contact cards for John Doe makes it confusing to the user. In the worst case, because the functionality is to track the records of employees, I would not be able to distinguish which employee card I want to find, which makes it a major feature flaw. Note that this bug have to be at least of higher severity than low severity because it can affect normal operations based on user stories.

For instance, if the same name appears to take the same leave, then I am unable to easily distinguish which john took the leave, affecting other functionality.

If identical names, address, and bank account (unlikely) were allowed to be added into the application, it should have been specified in the user guide, else the user might be confused.

---

_{[original: nus-cs2103-AY2324S1/pe-interim#1326] [original labels: type.FeatureFlaw severity.Medium]}

[jibtaf]

Team's Response

Thanks for raising this!
Our rule of thumb of checking whether two employees are the same one is whether their NAME, EMAIL, PHONE, ADDRESS, BANK_ACCOUNT, JOIN_DATE, SALARY and ANNUAL_LEAVE are all identical. Although it may make users confused, but this does happen in real life that two people with the same name work in the same company. So the user should make sure they can distinguish this two people before adding them, e.g., use John Doe 1 and John Doe 2.
As for the case where two employees with all fields identical but with names in different cases, i.e., John Doe and john doe, we have mentioned this in the planned enhancement section of our DG.

Duplicate status (if any):

--