search

nus-cs2103-AY2324S1 / pe-dev-response

0 stars 0 forks source link

Can add and edit email and address to be the "empty/default" value #1779

Open nus-se-script opened 9 months ago

nus-se-script commented 9 months ago

image.png

How to replicate: enter add-dentist n/John Doe p/98765432 s/Orthodontics y/5 followed by edit-dentist 8 e/NoEmailProvided@ToBeAdded.com

similar issue: edit-dentist 8 h/No Address Provided

Actual: This will change the value in the email and address respectively to the same "empty/default" (meant to represent that no email/address has been entered).

Expected: There should be a warning shown that you cannot set the email/address to be the "empty/default" value as the user clearly does not intend to use such a value as a email/address. Alternatively a different "empty/default" value could be use that the user more likely will not key as a email/address.

[original: nus-cs2103-AY2324S1/pe-interim#1374] [original labels: severity.Low type.FeatureFlaw]

freddychenyouren2 commented 9 months ago

Team's Response

Thank you for your report. However, it is hard for us to believe that users would end up in such a situation.

The user would have keyed in a valid email and/or address beforehand and we do not see a strong reason for the user to edit back to the default values.

The default values are only meant to be placeholders where users initially do not have information about the email/address of a specific patient/dentist. This is also part of our design consideration to allow the flexibility for faster data entry for patients and dentist, increasing the work efficiency of our target users.

Duplicate status (if any):

--