addleave currently does not consider public holidays or weekends

[nus-se-script]

Currently, adding leave over a 14 day period uses all 14 days of leave whereas in reality weekends and public holidays need to be considered. For example, if an employee wanted to be gone for 14 days they would need, at most, 10 days of leave since there are weekends. This could be problematic if an employee wants to use all their leave at once and the user does not remember this, causing them to use extra days of leave.

The command:

addleave id/EID2024-5678 from/2022-02-01 to/2022-02-14

Blocks out all 14 days of leave.

---

_{[original: nus-cs2103-AY2324S1/pe-interim#1385] [original labels: severity.Low type.FeatureFlaw]}

[JasonRay168]

Team's Response

Not in Scope: We decided not to restrict leave dates as pointed out by the tester due to the considerations of other industries which might not adhere to the typical 5 day work week, for instance in the hospitality industry (restaurants, hotels, etc.). Employees working in such industries may consider weekends and public holidays as working days, and as such it would be possible for them to apply for leave on those dates. Therefore, in our current iteration, it would not be reasonable to exclude leave dates on weekends and public holidays.

Nonetheless, this is a valid concern, which can be addressed with an additional feature allowing users to specify which dates or days are considered non-working days (leaves cannot be applied on these dates), which is not yet implemented and cannot be used by the user. It could be implemented in future iterations, but at the current iteration, we believe that what we currently have is sufficient, therefore we would classify this flaw as not in scope.

Duplicate status (if any):

--