nus-cs2103-AY2324S1 / pe-dev-response

0 stars 0 forks source link

Indefinite phone number length #1809

Open nus-se-script opened 11 months ago

nus-se-script commented 11 months ago

image.png

Minor nit that phone numbers currently can be input with indefinite number of digits without any errors. Maybe there should be error handling for such edge-cases to prevent accidental user input?


[original: nus-cs2103-AY2324S1/pe-interim#1391] [original labels: severity.Low type.FeatureFlaw]

adhigop13 commented 11 months ago

Team's Response

Though we agree that there should be some kind of hard limit on the number of digits for the phone number, we did not enforce any since phone number lengths can vary depending on country code, area codes etc. Hence it is not really in the scope for this project. Besides, if the user enters the wrong number, they can easily edit it to the correct number using our 'Edit' command.

Duplicate status (if any):

--