search

nus-cs2103-AY2324S1 / pe-dev-response

0 stars 0 forks source link

Able to create person who is NotAvailable with a valid animal name and animalType of able.Cat #1900

Open nus-se-script opened 10 months ago

nus-se-script commented 10 months ago

Steps to reproduce:

  1. Add a person without a pet add n/Jerry Hughes p/98765412 e/jerry123@example.com a/61 Baker Street housing/nil availability/Available animal/nil animalType/able.Cat

  2. Edit edit 24 availability/NotAvailable animal/burger

image.png

This can happen if the person recently adopted a pet, and the person updating the address book forgets to update the animalType.

Because the animalType is not updated, the fosterer is not counted in the stats current command, when it should. This can lead to problems counting the number of fosterers when there are a lot of fosterers to keep track of.

[original: nus-cs2103-AY2324S1/pe-interim#1446] [original labels: type.FeatureFlaw severity.Medium]

nananakx-x commented 10 months ago

Team's Response

Thank you for the feedback! We agree with this and upon a closer check of our code, we realised this can be resolved together with the issue #1897.

image.png

Duplicate status (if any):

--