nus-cs2103-AY2324S1 / pe-dev-response

0 stars 0 forks source link

Duplicate Detection using unique `name` may not be enough #1903

Open nus-se-script opened 11 months ago

nus-se-script commented 11 months ago

image.png

image.png

As stated in the guidelines, Hypothetically, in the case of jon lee being the same person(user entered duplicate person) and jon lee or jon lee and Jon Lee, it is unlikely to mean they are two different persons. (e.g., the user typed an extra space between the two names). Hence, typically, it is best if you can give a warning in such near match cases so that the user can make the final decision.

Since your team checks for duplicates with uniqueness of NAME and there is no warning given to the user when the user types an extra space between the two names or when the two names are the same but have different case-sensitivities, there might be potential duplicate cases going undetected. This is further compounded by the example used in your UG of John Doe (Company A) vs John Doe (Company B) where once aforementioned duplicates go undetected, the user may add the wrong company note in brackets to one John Doe but not the other duplicate john doe.

However, this is a minor inconvenience only, hence severity*low.


[original: nus-cs2103-AY2324S1/pe-interim#1449] [original labels: severity.Low type.FeatureFlaw]

KamiliArsyad commented 11 months ago

Team's Response

No details provided by team.

Duplicate status (if any):

Duplicate of #5929