nus-cs2103-AY2324S1 / pe-dev-response

0 stars 0 forks source link

Editing allows for duplicate **number**, **tele handle** and **email** #2034

Open nus-se-script opened 11 months ago

nus-se-script commented 11 months ago

Initially, the user in index 1 have different fields for number, tele handle and email. However, while using the edit feature, I am allowed to edit the parameters to duplicate that of user in index 2.

However in the real world, number, tele handle and email are all unique to individuals, hence the application should implement checks to handle duplicates.

image.png


[original: nus-cs2103-AY2324S1/pe-interim#1547] [original labels: severity.Low type.FunctionalityBug]

Originalidk commented 11 months ago

Team's Response

We believe this to be a duplicate of another bug. In that bug, it states that "I can add a new student with the same particulars as another student (see students 8 and 9) , and that should not be allowed as it is unlikely for students to have the same phone number, email, or telegram handle, as such the app should warn me if i mistakenly add duplicate particulars.". The issue brought up here is that users are allowed to have the same phone number, email or telegram handle for the edit command. Let us refer to the CS2103T website to see what constitutes a duplicate bug.

Bug Duplicate.png

As shown in the image above, "Multiple buggy behaviors that are actually caused by the same defect and cannot be fixed independently (i.e., fixing one fixes the others automatically)" are considered duplicate bugs. As the issue of having duplicate persons for both the add and edit commands is caused by our duplicate checker not checking email, telegram handles and phone numbers, fixing one would fix the other (as both edit and add use the same duplicate person checker). Thus, this is a duplicate.

Duplicate status (if any):

Duplicate of #1558