nus-cs2103-AY2324S1 / pe-dev-response

0 stars 0 forks source link

Name doesn't allow special characters #2060

Open nus-se-script opened 9 months ago

nus-se-script commented 9 months ago

Certain individuals may have non-alphanumeric characters in their names. The current application limits this by throwing an error message when i.e., John s/o Doe is used as the name in the addstaff command.

Command input: addstaff n/John s/o Doe p/98765432 e/johnd@example.com a/311, Clementi Ave 2, #02-25 t/friends t/owesMoney

Output: Names should only contain alphanumeric characters and spaces, and it should not be blank

Screenshot 2023-11-17 at 4.26.06 PM.png


[original: nus-cs2103-AY2324S1/pe-interim#1570] [original labels: severity.Low type.FeatureFlaw]

AlainS87 commented 9 months ago

Team's Response

We do see the inconvenience this causes for people with certain characters in their name.

However, we will classify it as Not In Scope as accounting for such cases will require an overhaul of the parsing system, hence there is a low value/effort ratio considering the user can omit the / or replace it with a space without impacting the identifiability of the name much. It is also mentioned in the UG that names only accept letters and digits, and fails gracefully with an error message, hence fulfilling the condition for NotInScope.

Duplicate status (if any):

--