nus-cs2103-AY2324S1 / pe-dev-response

0 stars 0 forks source link

Users with the same details allowed #2389

Open nus-se-script opened 11 months ago

nus-se-script commented 11 months ago

Two users can have the exact same phone numbers, telegram handles and emails. While this can be true for other attributes like a home address for brothers for example, this is untrue for unique identifiers like phone numbers, telegram handles and email accounts which are unique to an individual student. The app would be much more robust if the duplicate entry validation takes this into account Screenshot 2023-11-17 at 4.36.00 PM.png


[original: nus-cs2103-AY2324S1/pe-interim#3545] [original labels: type.FeatureFlaw severity.Medium]

Originalidk commented 11 months ago

Team's Response

We believe this to be a duplicate of another bug. In that bug, it states that "I can add a new student with the same particulars as another student (see students 8 and 9) , and that should not be allowed as it is unlikely for students to have the same phone number, email, or telegram handle, as such the app should warn me if i mistakenly add duplicate particulars". The issue brought up here is that users are allowed to have the same phone number, email or telegram handle. Let us refer to the CS2103T website to see what constitutes a duplicate bug.

Bug Duplicate.png

As shown in the image above, "Multiple buggy behaviors that are actually caused by the same defect and cannot be fixed independently (i.e., fixing one fixes the others automatically)" are considered duplicate bugs. As the issue of having duplicate persons is caused by our duplicate checker not checking email, telegram handles and phone numbers, fixing the checker would fix the this issue (as both issues are caused by the duplicate person checker not working). Thus, this is a duplicate.

Duplicate status (if any):

Duplicate of #1558