search

nus-cs2103-AY2324S1 / pe-dev-response

0 stars 0 forks source link

find-t command does not work correctly #3122

Open nus-se-script opened 11 months ago

nus-se-script commented 11 months ago

In my addressbook, I have 2 tutors named Lee Jun Hong and Lee Jun Ming. Inputting find-t Lee Jun Hong returns both of these tutors

image.png

While I understand that it was stated in the UG that this is intentional, I believe that this may cause future inconveniences for the user. For instance, if we have 1000 tutors with surname Lee, and I only wish to look for the particulars of Lee Jun Hong specifically. it would mean that I still have to sieve through 1000 different tutors to find his particulars.

Moreover, if a specific name was keyed in, I would believe that the user is intending to search for that exact matching name

[original: nus-cs2103-AY2324S1/pe-interim#4452] [original labels: type.FeatureFlaw severity.Medium]

saltedfishxx commented 11 months ago

Team's Response

The search behaviour is designed as such for a few reasons (bolded in the explanation below).

While it's true that searching for a common surname might yield a large number of results, it's essential to understand that the current feature was designed to allow for flexibility in case a user wants to see a broader list of tutors. The search behaviour is designed to show the most number of results as possible, such that there is no chance that the person the user is searching for does not appear in the filtered list shown.

Additionally, users can leverage this behaviour to include more keywords in just one command. In a scenario where a tuition centre coordinator wants to find all tutors whose surnames are Tan and Lee, find-t Lee Tan would work. In your proposed implementation, this search result is impossible.

Regarding your concern, the search behaviour was clearly documented in the UG as you pointed out. As such, advanced users in this case who are searching specifically for Lee Jun Hong can understand from the search behaviour documentation that inputting 'Hong' as the keyword would be more beneficial to them (fewer keywords, more narrow search). Thus, with current implementation of search behaviour, it is not impossible to return Lee Jun Hong.

The severity of this issue should also be lowered to Low, since it is rare that there will be 1000 tutors with the surname Lee.

Duplicate status (if any):

--