nus-cs2103-AY2324S1 / pe-dev-response

0 stars 0 forks source link

Duplicate email addresses are allowed #3309

Open nus-se-script opened 1 year ago

nus-se-script commented 1 year ago

Steps to reproduce:

  1. use the commands addPerson n=A p=98765432 e=johnd@example.com a=John street, block 123,#01-01 addPerson n=A1 p=98765432 e=johnd@example.com a=John street, block 123,#01-01

スクリーンショット 2023-11-17 午後4.16.29.png

Allowing for 2 people to possess the same email address, would this be realistic in a practical sense?


[original: nus-cs2103-AY2324S1/pe-interim#2587] [original labels: severity.Low type.FunctionalityBug]

wui-hong commented 12 months ago

Team's Response

Thank you for your bug report. This is a duplicate of another issue, but the same response applies.

In our application, we have decided that names are unique to identify people with respect to the needs of our target audience. However, allowing Telegram Handles, phone numbers and email addresses to be duplicated is an intentional choice of our application. This applies for both the addPerson and editPerson commands. 
Making addresses not unique was more straightforward as multiple people can live in the same place. However, for the other fields, there was more to consider. In some cases, it is possible that a contact does not want to disclose their direct personal details (phone number / email / Telegram). They may instead disclose a more general phone contact. Some examples where multiple people may share the same contact details include:


We aim to be flexible with our application, only restricting uniqueness in names as it is necessary, whereas giving the freedom for users to have duplicates in other fields. Overly enforcing the uniqueness of fields can be seen as overzealous validation that may inconvenience our target audience who may encounter contacts with common details. This design decision aligns with real examples that accommodates to the diverse user needs, and follows common standards in leading contact management applications such as Apple Contacts where flexibility in contact details is allowed.


Duplicate status (if any):

Duplicate of #4239