nus-cs2103-AY2324S1 / pe-dev-response

0 stars 0 forks source link

Date of Birth allowed after Date of Admission if edited from data file directly #3461

Open nus-se-script opened 10 months ago

nus-se-script commented 10 months ago

Screenshot 2023-11-17 at 4.52.38 PM.png

I edited the data file to have the Date of Birth after the Date of Admission. It should not be allowed, but no error is thrown and messes with the Age of the Animal as well.

this is the corresponding data field edited:

Screenshot 2023-11-17 at 4.54.42 PM.png


[original: nus-cs2103-AY2324S1/pe-interim#2695] [original labels: type.FunctionalityBug severity.Medium]

euchangxian commented 10 months ago

Team's Response

Editing the json file is something that the user should know what they are doing. Besides, the age of the animal is correctly displayed based on the date of the PE (17 November 2023). The only bug we would accept is that the DOB < DOA constraint is violated, which is a duplicate of the edit command.

Duplicate status (if any):

Duplicate of #5843