search

nus-cs2103-AY2324S1 / pe-dev-response

0 stars 0 forks source link

Reference to AB3 in storage json #3641

Open nus-se-script opened 11 months ago

nus-se-script commented 11 months ago

Description

The .json file storing the data for JABPro is still using addressbook.json as its name despite the product not being AB3 anymore.

Expected

Should be named more generally or matching the current product.

Actual

Still following AB3 naming.

Steps to Reproduce

  1. Launch JABPro using the terminal
  2. Key in a command like list to generate the data folder and storage jsons.
  3. Open the data folder and notice that its name is addressbook.json.

[original: nus-cs2103-AY2324S1/pe-interim#5048] [original labels: type.FeatureFlaw severity.VeryLow]

ScarletBlanks commented 11 months ago

Team's Response

We believe that this is also considered a duplicate of #5418 because both can be fixed at the same time by simply refactoring all instances of addressbook to jabpro.

Duplicate status (if any):

Duplicate of #5418