search

nus-cs2103-AY2324S1 / pe-dev-response

0 stars 0 forks source link

Names should take upper case and lower case into account #4499

Open nus-se-script opened 1 year ago

nus-se-script commented 1 year ago

Description

Screenshot 2023-11-17 at 4.36.53 PM.png

Screenshot 2023-11-17 at 4.41.34 PM.png

Similar to the feature flaw on names with spaces As can be seen in the screenshot, both individuals have the exact same details only one is upper case and the other is lower case.

Reason to why its Flawed

Duplicate data entries are allowed.

Justification for Severity Level

It should be very common for tutors/individuals to accidentally type students names as lower or upper case. Tutors may have forgotten that they have added this particular student and have double entries for them. With that tutors will have duplicate data and may start adding information to one and neglect the other. They may see the other entry (the one they have not been adding information to) and think that that is the correct data but that is not the case. Creates a lot of confusion for tutors and they may start asking tutees to make payment twice or change timing yet not realise it is changed.

[original: nus-cs2103-AY2324S1/pe-interim#3488] [original labels: type.FeatureFlaw severity.Medium]

WinstonLeonard commented 1 year ago

Team's Response

While it is a valid bug, our team decided this a low severity level for the following reasons which make the above scenario very unlikely to occur:

  1. In a scenario where you forget whether you have previously input the tutee details and made typed the tutee's name with a different case, all other inputs should remain the same. Hence, the schedule will clash. Therefore, it will prevent you from adding the same tutee again to the system.

  2. Second of all, in a real-life scenario, you will only accept and add a tutee once into the system. In the case you've forgotten whether you've added this tutee to the system, a simple find command will suffice (which is case-insensitive).

Given that duplicate detection is not trivial as explained below, and that inputting duplicates are unlikely due to the above reasons, our team decided to prioritise other more pressing bug fixes and features in v1.3 and v1.4 and hence categorised this as not in scope.

Untitled.png

Duplicate status (if any):

--