search

nus-cs2103-AY2324S1 / pe-dev-response

0 stars 0 forks source link

Missing duplicate person Use case for Add a person to the contact list (UC1) #4849

Open nus-se-script opened 11 months ago

nus-se-script commented 11 months ago

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.

Lacks the duplicate person extension for when adding a new person who already exists. Just stating that the particulars are invalid is insufficient (As all the particulars abide by the remarks for valid fields)

[original: nus-cs2103-AY2324S1/pe-interim#4014] [original labels: severity.Low type.DocumentationBug]

freshcabbage123 commented 11 months ago

Team's Response

Due to the lack of screenshots and explanations provided on your end, this is our current understanding of your issue.

The definition of invalid is not as narrowly defined as just the specifications highlighted in the fields table as suggested by the test. Attempting to add a person that already exists (i.e. duplicate person) will be a case of adding invalid particulars, as seen in the potential errors table: "This person already exists in the address book”. It should then be clear to the tester that the user should take the correct step to resolve the error message by removing/amending the invalid particulars.

As such, the reported bug of missing the extension of a duplicate person is unnecessary, as our current extension of invalid input already covers the case of adding a duplicate person. Repeating this in another extension does not bring any extra value.

Duplicate status (if any):

--