nus-cs2103-AY2324S1 / pe-dev-response

0 stars 0 forks source link

Duplicate email can be added #4896

Open nus-se-script opened 10 months ago

nus-se-script commented 10 months ago

As seen below, I can add two people with the same email. As a HR application that manages contacts, I think this violates the spirit of your app because at no time would there be two people with the same email address in a team - or ever. This can cause erroneous inputs and emails to be added to the application.

image.png


[original: nus-cs2103-AY2324S1/pe-interim#4112] [original labels: severity.Low type.FeatureFlaw]

ryanozx commented 10 months ago

Team's Response

There may be cases in which multiple contacts can share the same work email addresses

As such, we have chosen to not enforce uniqueness on email addresses in the employee list.

Duplicate status (if any):

--