search

nus-cs2103-AY2324S1 / pe-dev-response

0 stars 0 forks source link

Duplicate detection #526

Open nus-se-script opened 10 months ago

nus-se-script commented 10 months ago

image.png

Users are able to add duplicates of the same person with the same details, if unimportant changes are made to some fields. Contacts having the same phone number and email address should be identified as a duplicate.

For example, in the above image, notice how Contact 1 and Contact 2 have the exact same name, phone number and email, which should have been noted as a duplicate. However, since the address is typed differently (Avenue instead of Ave, which is likely to happen), the duplicate contact is allowed to be added.

Also, note how Contact 1 and Contact 3 contain the exact same information, other than the capitalization of the name. This should also be flagged as a duplicate.

Especially when the contact list is big, the user will not be able to notice such duplicates, which should definitely be caught and brought up by the app.

Steps to reproduce:

  1. Use clear to start with an empty contact list
  2. Enter add contact -n Aaron -p 12345678 -a Yishun Ave 7 -e aaron123@gmail.com
  3. Enter add contact -n Aaron -p 12345678 -a Yishun Avenue 7 -e aaron123@gmail.com
  4. Enter add contact -n aaron -p 12345678 -a Yishun Ave 7 -e aaron123@gmail.com

[original: nus-cs2103-AY2324S1/pe-interim#651] [original labels: type.FeatureFlaw severity.Medium]

Nixx162 commented 9 months ago

Team's Response

No details provided by team.

Duplicate status (if any):

Duplicate of #920