nus-cs2103-AY2324S1 / pe-dev-response

0 stars 0 forks source link

Inaccurate error message for negative ID #6022

Open nus-se-script opened 1 year ago

nus-se-script commented 1 year ago

I put -1 as the customer id when calling customer view command. Instead of getting an exception message indicating invalid CUSTOMER ID, which is displayed for out-of-range indexes, I got Invalid Command Format.

Screenshot 2023-11-17 at 5.02.14 PM.png


[original: nus-cs2103-AY2324S1/pe-interim#6016] [original labels: type.FunctionalityBug severity.Medium]

juliusgambe commented 1 year ago

Team's Response

Rejected due to planned enhancements #10 - For inputting a negative value for certain numerical parameters currently results in "Invalid Command Format". It should have a more specific error message which is a feature flaw.

Screenshot 2023-11-19 at 11.10.17 PM.png

photo_2023-11-19 22.56.04.jpeg

Furthemore, the UG already states the definition of the correct command format when DELIVERY_ID and CUSTOMER_ID are included:

photo_2023-11-20 12.24.47.jpeg

Duplicate status (if any):

--