nus-cs2103-AY2324S1 / pe-dev-response

0 stars 0 forks source link

Negative index is not detected #6024

Open nus-se-script opened 1 year ago

nus-se-script commented 1 year ago

Negative index for delivery is not detected. Screenshot 2023-11-17 at 5.10.22 PM.png


[original: nus-cs2103-AY2324S1/pe-interim#6018] [original labels: type.FunctionalityBug severity.Medium]

juliusgambe commented 1 year ago

Team's Response

Negative index is detected, thus, the error message include states that there is a problem with the command format as the DELIVERY_ID must be a positive integer and less than the Integer.MAX_VALUE.

Furthemore, the UG already states the definition of the correct command format when DELIVERY_ID and CUSTOMER_ID are included:

photo_2023-11-20 12.24.47.jpeg

Hence, it is more of an issue of specificity of error message which is a feature flaw according to the textbook and as it only gives minor inconvenience to the user, the severity is low.

photo_2023-11-19 22.56.04.jpeg

However, this is already part of planned enhancement #10, thus, it is rejected.

Screenshot 2023-11-19 at 10.51.27 PM.png

Duplicate status (if any):

--