nus-cs2103-AY2324S1 / pe-dev-response

0 stars 0 forks source link

Able to create deadlines which go beyond the Cycle period #6026

Open nus-se-script opened 1 year ago

nus-se-script commented 1 year ago

I tried to add an application deadline which is much after the internship cycle period. LetsGetHired accepts this input and creates the intern application.

add r/Developer n/Google c/June 2018 s/Pending d/12 May 2026

image.png


[original: nus-cs2103-AY2324S1/pe-interim#6023] [original labels: type.FeatureFlaw severity.Medium]

zsh-eng commented 1 year ago

Team's Response

Thanks for pointing this out! However, our team does not believe that this is a bug.

There are 2 main reasons why the deadline specified can be any date.

  1. We do not restrict the input for the cycle field, to provide versatility for the user. Thus, users can input Summer or Winter without a year and this input is still accepted. Thus, there is no way to restrict the deadlines based on the cycle.
  2. As per the UG, users are given the flexibility to use the deadline for any other crucial dates. One use case we can think of is putting all "final deadlines" as your graduation date, and in such a case 12 May 2026, which you provided as an input, can be a reasonable deadline.

image.png

Duplicate status (if any):

--