nus-cs2103-AY2324S1 / pe-dev-response

0 stars 0 forks source link

Bug in FIND when the INDEX is negative #631

Open nus-se-script opened 11 months ago

nus-se-script commented 11 months ago

image.png

Enter find -3 and this is what the UI returns me with no error messages

Same issue for find 0

This is could make the product almost unusable especially when room numbers are between 1 and 500


[original: nus-cs2103-AY2324S1/pe-interim#540] [original labels: type.FeatureFlaw severity.High]

RB9823 commented 11 months ago

Team's Response

This issue is denied as both the User and Developer guides clearly outline the valid range for the Room Numbers (1 to 500 inclusive):

image.png

As such, not only is the user unlikely to ever search for a zero or negative room number (as it is out of the accepted range), the existing message as shown in the screenshot provided:

Screenshot 2023-11-18 at 9.49.28 PM.png

clearly indicates that no such bookings can be found.

Additionally, as the find command is used to search by name:

image.png

and several names involve the '-' symbol, the find command cannot be modified to strictly reject the '-' symbol.

Duplicate status (if any):

--