nus-cs2103-AY2324S1 / pe-dev-response

0 stars 0 forks source link

Incorrect sequence diagrams #641

Open nus-se-script opened 8 months ago

nus-se-script commented 8 months ago

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.


Objects such as Interview and Applicant are created within the Logic component e.g. AddInterviewCommand.java, as such the object should not be shown under the Model section but Logic section.

  1. Interview should be under Logic section for AddInterviewCommand.java:

image.png

  1. JobContainsKeywordsPredicate should be under Logic section for FindCommandParser.java

image.png

  1. NameContainsKeywordsPredicate and ApplicantPredicate should be under Logic section for FindCommandParser.java image.png

[original: nus-cs2103-AY2324S1/pe-interim#792] [original labels: type.DocumentationBug severity.VeryLow]

jingjie88 commented 8 months ago

Team's Response

image.png

As seen in the image above, the predicates are under model and not logic. The sequence diagram is correct.

Duplicate status (if any):

--