nus-cs2103-AY2324S1 / pe-dev-response

0 stars 0 forks source link

Job Role should have some string contraints #692

Open nus-se-script opened 10 months ago

nus-se-script commented 10 months ago
  1. While it is good for the users to not have any constraint when entering the Job Role for a new interview, it is not practical for the application and usage that users are allowed to enter special characters only.

  2. E.g. When adding a new interview, Job role is specified as @#$#@ which does not bear any meaning to any job role resemblence.

image.png

  1. Reccomended to still include a form of constraint, e.g. at least have alphanumeric, while allowing special characters, or reject any string that contains special characters only.

[original: nus-cs2103-AY2324S1/pe-interim#591] [original labels: severity.Low type.FeatureFlaw]

ghost commented 10 months ago

Team's Response

Elon Musk's son name is X Æ A-Xii

With how weird the world is going these days, there's no gaurantee that someone will not come up with a weird job role name. It also does not make sense to unnecessarily constrain the user as since this application is intended for internal usage, certain special characters can be used for the user of the application to quickly find all of their "special" tagged upcoming interviews. (E.g. I decide to use @ as a short form to tag all Account Executives, and # to tag all Sales Engineers, because I am the user I should be allowed to have the freedom to use whatever abbreviations I feel most comfortable with in order to make my work quicker)

Duplicate status (if any):

--