nus-cs2103-AY2324S2 / forum

16 stars 0 forks source link

Incorrect help message #826

Closed YowSiaoKang closed 7 months ago

YowSiaoKang commented 7 months ago
Emails should be of the format local-part@domain and adhere to the following constraints:
1. The local-part should only contain alphanumeric characters and these special characters, excluding the parentheses, (+_.-). The local-part may not start or end with any special characters.
2. This is followed by a '@' and then a domain name. The domain name is made up of domain labels separated by periods.
The domain name must:
    - end with a domain label at least 2 characters long
    - have each domain label start and end with alphanumeric characters
    - have each domain label consist of alphanumeric characters, separated only by hyphens, if any.

For the following emails supplied, the above help message will be shown which seems to be an invalid help message.

I would like to clarify if fixing of the help message in our app is allowed. Thank you!

damithc commented 7 months ago

@YowSiaoKang What's the proposed change to the error message?

YowSiaoKang commented 7 months ago

Emails should be of the format local-part@domain and adhere to the following constraints:

  1. The local-part should only contain alphanumeric characters and these special characters, excluding the parentheses, (+_.-). Special characters must not be consecutive and the local-part may not start or end with any special characters.
  2. This is followed by a '@' and then a domain name. The domain name is made up of domain labels separated by periods. The domain name must:
    • end with a domain label at least 2 characters long
    • have each domain label start and end with alphanumeric characters
    • have each domain label consist of alphanumeric characters, separated only by a single hyphen, if any. Ending domain label should not contain any hyphens.
damithc commented 7 months ago

@YowSiaoKang Yes, you can update the error message.

YowSiaoKang commented 7 months ago

Thank you prof!!! @damithc