nus-cs2103-AY2324S2 / forum

16 stars 0 forks source link

AB3 code reused #839

Closed Ko-Khan closed 7 months ago

Ko-Khan commented 7 months ago

I had reused some of the classes from AB3 such as JsonAdaptedPerson and modified them to create classes such as JsonAdaptedArticle, JsonSerializableArticleBook. Do I need to declare this under reuse and will these new classes count towards my total lines of code written?

damithc commented 7 months ago

@Ko-Khan As per the below, following AB3 code need not be considered as reuse.

image

Ko-Khan commented 7 months ago

When they say ensure such code doesn't appear under your name in the tP code dashboard, does this mean that classes I added should not contribute to total lines of code written if they reuse AB3 code?

damithc commented 7 months ago

When they say ensure such code doesn't appear under your name in the tP code dashboard, does this mean that classes I added should not contribute to total lines of code written if they reuse AB3 code?

@Ko-Khan No, it refers to existing AB3 code, not code you added that follow existing code.