search

nus-cs2103-AY2324S2 / forum

16 stars 0 forks source link

Is adding validation checks for json files considered a feature freeze violation? #842

Open logical-1985516 opened 7 months ago

logical-1985516 commented 7 months ago

Hi Prof, may I ask whether it is ok to add code to perform checks on the json objects, so that certain edits to the data file would not cause the app to crash? E.g. checking if a certain attribute in a json object is null to prevent potential NPEs. Adding on to #837.

damithc commented 7 months ago

@logical-1985516 Yes, it would be enhancing a feature, as the crash prevention is an enhancement that is currently neither implemented nor promised in the UG.

logical-1985516 commented 7 months ago

Thank you Prof for your response. Would this be considered a bug/feature flaw?

damithc commented 7 months ago

Enhancement implies feature flaw.