nus-cs2103-AY2324S2 / forum

16 stars 0 forks source link

Git commit messages #845

Closed chiralcentre closed 7 months ago

chiralcentre commented 7 months ago

Can I check with the teaching team if we will be penalised for not following Git commit message conventions? Currently I noticed that I forgot to capitalise the first word of my commit messages thus far. Is there any way to remedy this before the deadline?

damithc commented 7 months ago

@chiralcentre Yes, it is graded. We only check the last 10 commits though.

chiralcentre commented 7 months ago

Thank you Prof for the response! Just to clarify, are you referring to the last 10 commits in master for each person, or the last 10 commits in master as a whole?

damithc commented 7 months ago

Thank you Prof for the response! Just to clarify, are you referring to the last 10 commits in master for each person, or the last 10 commits in master as a whole?

@chiralcentre each person. Note that commits of a merged branch become commits of the master branch. So, if you were to merge a branch with 10 of your commits, those 10 commits will be counted as your commits in the master branch.

drustanyjt commented 7 months ago

@damithc our team was working on documentation together by going through each line, committing at every few lines of changes, and as a result our most recent commits look something like this:

image

While it technically follows the formatting instructions of messages, would it be better to reset and squash the repetitive commits into one (for grading purposes)?

damithc commented 7 months ago

@drustanyjt Small commits are good. In future, you can make the commit message more descriptive e.g., Fix typo in DG: haad -> had