search

nus-cs2103-AY2324S2 / forum

16 stars 0 forks source link

Refactoring #987

Open RunjiaChen opened 6 months ago

RunjiaChen commented 6 months ago

image Can the last option be correct as well? Since refactoring is the process of improving internal structure, but in this case he's actually making it worse by violating the coding standards

baskargopinath commented 6 months ago

last option doesn't result in any external behaviour change and is just a design change to the internal structure (which could be interpreted as an improvement by making the code neater) so i think it is still refactoring

damithc commented 6 months ago

last option doesn't result in any external behaviour change and is just a design change to the internal structure (which could be interpreted as an improvement by making the code neater) so i think it is still refactoring

Yup.

Since refactoring is the process of improving internal structure, but in this case he's actually making it worse by violating the coding standards

Also, we don't know what coding standard Tom is using.