nus-cs2103-AY2324S2 / pe-dev-response

0 stars 0 forks source link

Overzealous input blocking (phone number) #1026

Open nus-se-script opened 4 months ago

nus-se-script commented 4 months ago

Screenshot 2024-04-19 at 4.39.29 PM.jpg

Overzealous input blocking for allowing only one phone number, which does not add any value but allowing it does. Suggestion:

It is better to warn rather than to block when inputs are not compliant with the expected format, unless accepting such inputs can hinder the operations of the software. Allowing such flexibility can in turn allow the user to use the software in ways you didn't even anticipate while overzealous rejection of inputs can annoy the user!

For example: A user might want to input 1234 5678 (HP) 1111-3333 (Office) -- blocking that input might not add any value but allowing it does.

steps to reproduce: add n/test test t p/112 p/1122 e/test@test t/Pneumonoultramicroscopicsilico


[original: nus-cs2103-AY2324S2/pe-interim#856] [original labels: severity.Medium type.FeatureFlaw]

Jolonauh commented 4 months ago

Team's Response

The above scenario is not an instance of overzealous input. The user is trying to use two of the same parameters in one command, which is a different issue from overzealous input.

The error message shown is an accurate description of the issue (using 2 of the same parameters in 1 command). Moreover, in the UG it is stated that phone no. parameter is only single-valued and the client cannot have multiple emails. Therefore, we would like to reject this issue.

Additionally, we recommend the severity to be decreased from Medium to Low as the issue only causes minor inconvenience.

Duplicate status (if any):

Duplicate of #669