search

nus-cs2103-AY2324S2 / pe-dev-response

0 stars 0 forks source link

Edit commands lets the user input invalid numbers #1166

Open nus-se-script opened 5 months ago

nus-se-script commented 5 months ago

Issue mentioned: As seen in the picture below, the edit command can be used to edit the number of a person to a number that can not exist.

Screenshot 2024-04-19 at 4.32.20 PM.png

Steps to reproduce: edit 1 p/1231

Steps to rectify: Perhaps, the team can set a limit of 8-10 valid numbers that must be there for the number input to get accepted! I am aware that the team has set a limit of 3 valid numbers already, but this still allows for the enter of invalid numbers

Regards!

[original: nus-cs2103-AY2324S2/pe-interim#968] [original labels: severity.Low type.FeatureFlaw]

zhekaiii commented 5 months ago

Team's Response

There are valid numbers that are 3 digit long, e.g. 999, 995, 911.

1777 is the number for non-emergency ambulance in Singapore.

Users might want to add these as contacts on FriendFolio because it is after all an address book application.

Duplicate status (if any):

--