nus-cs2103-AY2324S2 / pe-dev-response

0 stars 0 forks source link

Undo does not work as expected #1212

Open nus-pe-bot opened 5 months ago

nus-pe-bot commented 5 months ago

Screenshot 2024-04-19 at 4.34.23 PM.png

When using undo successively, it would be better to state that undo would undo the commands executed previously excluding the undo function itself. If I were a user expecting undo to undo the effects of the undo command, in the case where my first undo was to undo a clear command, I would expect the second undo to clear the address book again.

Eg. step 1: clear step 2: undo (restores contacts) step 3: undo (should remove contacts)

Screenshot 2024-04-19 at 4.37.32 PM.png

In this case, the first undo command did edit the user list, thus I would expect the second undp to revert the first undo.


[original: nus-cs2103-AY2324S2/pe-interim#1538] [original labels: severity.Low type.DocumentationBug]

lynnetteeee commented 5 months ago

Team's Response

The feature follows the conventions set by well-established applications like Microsoft Word, where when you undo twice, it is supposed to bring you back to 2 steps back, but if you want to revert the first undo, you would naturally use a redo, which is also part of our commands.

We designed the redo feature to revert an undo command, to prevent a naming clash and confusion when the user actually attempts to revert the undo command.

Duplicate status (if any):

--