nus-cs2103-AY2324S2 / pe-dev-response

0 stars 0 forks source link

Overzealous phone number parsing #1327

Open nus-se-script opened 2 months ago

nus-se-script commented 2 months ago

Steps to reproduce:

  1. Enter this command "add n/James Ho p/(H)1800 1111 2222 e/jamesho@example.com a/123,Clementi Rd, 1234665 t/friend t/colleague"

Expected: Valid phone number Actual: Error is shown below

image.png

Good job for the feature! It looks good, here’s something that could be a bug.


[original: nus-cs2103-AY2324S2/pe-interim#1092] [original labels: severity.Low type.FeatureFlaw]

AdityaB4 commented 2 months ago

Team's Response

Thanks for the bug report. While this would be a good-to-have, as stated by the CS2103T teaching team on the website, the developer team wanted to prioritise having a secure input without the possibility over having multiple latent use-cases for different users. As such, this is something that we could consider implementing if we had more iterations of the app, and would be considered not in scope.

Duplicate status (if any):

--