search

nus-cs2103-AY2324S2 / pe-dev-response

0 stars 0 forks source link

Whitespaces in parameter values are ignored quietly when they should either be permitted or intercepted by error message #1330

Open nus-se-script opened 2 months ago

nus-se-script commented 2 months ago

Description

When attempting to add a company name with a leading whitespace, the whitespace is trimmed for me before the company is added. There is no mention in the UG warning me that this will happen and neither is there any error message intercepting this operation if I cannot have leading whitespaces in my parameter values

Expected Outcome

When I execute add c/ Straits Times p/12345678 e/jobs@mediacorp-digital.com a/321 Media Lane, Singapore 238163 t/I jd/Product Design Intern d/11-06-2024 0900 id/3 months s/1000 n/Be prepared to discuss current trends in the me, either the company's name in the interview card should be " Straits Times" or there should be an error message explaining why this is not possible. The application should not disregard the name I want to set for the company and trim the spaces

Actual Outcome

image.png

Additional

Moreover, when I execute an edit command with an invalid c/ parameter, I get the following message:

image.png

Which further suggests spaces in names should not be ignored.

[original: nus-cs2103-AY2324S2/pe-interim#1685] [original labels: type.FunctionalityBug severity.Medium]

eunrcn commented 2 months ago

Team's Response

Severity.Low: A flaw that is unlikely to affect normal operations of the product. Appears only in very rare situations and causes a minor inconvenience only.

Response.NotInScope: It is a valid issue, but fixing it is less important than the work done in the current version of the product e.g., it was not related to features delivered in v1.4 or lower priority than the work already done in v1.4.

We understand your point of view but this falls within NotInScope and Severity.Low according to their description.

Duplicate status (if any):

--