search

nus-cs2103-AY2324S2 / pe-dev-response

0 stars 0 forks source link

No domain validation for email #1364

Open nus-pe-bot opened 4 months ago

nus-pe-bot commented 4 months ago

There is no validation for a clearly invalid email.

This could even be a Medium severity as it means that a user can make a mistake in typing the email for the company they applied for, but there is no validation by the app and is accepted. It could inconvenience the user when they refer back to the InternBook app, as they would not be able recall the email of the company they applied to from the application itself. This contradicts the goals of the InternBook app as it aims to be a one-stop platform for internship-seekers to view all their internship application at once.

image.png

image.png

[original: nus-cs2103-AY2324S2/pe-interim#1121] [original labels: severity.Low type.FeatureFlaw]

AjayArvind2207 commented 4 months ago

Team's Response

Thank you for the feedback! The email you entered is a perfectly valid email as per the syntax rules of email addresses, so our app has no reason to reject it.

Duplicate status (if any):

--